fix bug to depend on class name of Fluent::Plugin::MultiOutput #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, checking objects with its class name is wrong practice in Ruby. It's should be done with method calls. When v0.14 MultiOutput plugins are used, Plugin.new_output requires the class at first, so Fluent::Plugin::MultiOutput reference can succeed. When v0.12 MultiOutput plugins are used, it fails. Refenrencing classes in core code makes circular dependencies, so we should use method calls to check objects.
|
@repeatedly please check this fix. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, checking objects with its class name is wrong practice in Ruby. It's should be done with method calls.
When v0.14 MultiOutput plugins are used, Plugin.new_output requires the class at first, so Fluent::Plugin::MultiOutput reference
can succeed. When v0.12 MultiOutput plugins are used, it fails.
Refenrencing classes in core code makes circular dependencies, so we should use method calls to check objects.
This change fixes #1205.